Add params argument to _get_uuid_by_name #2071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslocrian
requested review from
gangaadhars,
chaitanyaavi and
manojkumarjain
as code owners
|
@mslocrian, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@mslocrian, VMware has approved your signed contributor license agreement. |
|
@gangaadhars / @chaitanyaavi / @manojkumarjain , where would be the best place to add the test results that the sdk is failing on? |
gangaadhars
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
delete_by_name()andput_by_name()methods ofApiSession()accept theparamsargument; however, they do not actually use it in the_get_uuid_by_name()call. This can be problematic if you have two objects with the same name that exist in different clouds.This PR adds params to those calls and associated methods.